Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: For Hubspot API module make redirect uri and state overridable #320

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

d-klotz
Copy link
Contributor

@d-klotz d-klotz commented Jul 29, 2024

This PR implements an optional params parameter to the getAuthorizationRequirements method that is an object containing redirect_uri and state properties. This will be useful when someone wants to pass a custom redirect_uri or state object to the Oauth flow.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @friggframework/[email protected]
# or 
yarn add @friggframework/[email protected]

@d-klotz d-klotz requested a review from seanspeaks July 29, 2024 17:45
Copy link

sonarcloud bot commented Jul 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
10.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@seanspeaks seanspeaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@d-klotz d-klotz merged commit fc16dab into version-0 Jul 29, 2024
4 of 6 checks passed
@d-klotz d-klotz deleted the feature/hubspot-make-redirectURL-overritable branch July 29, 2024 19:31
@seanspeaks seanspeaks added the released This issue/pull request has been released. label Jul 29, 2024
@seanspeaks
Copy link
Contributor

🚀 PR was released in @friggframework/[email protected] 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants